How to convince eslint that settings are defined? – dev

TPWAdmin

7 months ago

How to convince eslint that settings are defined? - dev 1

pfaffman
(Jay Pfaffman)

December 14, 2023, 4:00pm

1

/home/runner/work/discourse-custom-homepage-for-groups/discourse-custom-homepage-for-groups/javascripts/discourse/initializers/custom-homepage-set.js.es6
Error:   13:11  error  'settings' is not defined  no-undef
Error:   14:21  error  'settings' is not defined  no-undef
Error:   19:20  error  'settings' is not defined  no-undef
Error:   20:21  error  'settings' is not defined  no-undef
Error:   25:36  error  'settings' is not defined  no-undef
Error:   26:21  error  'settings' is not defined  no-undef
Error:   32:40  error  'settings' is not defined  no-undef
Error:   33:26  error  'settings' is not defined  no-undef

github.com

pfaffman/discourse-custom-homepage-for-groups/blob/main/javascripts/discourse/initializers/custom-homepage-set.js.es6

import mobile from "discourse/lib/mobile";
import { withPluginApi } from "discourse/lib/plugin-api";
import PreloadStore from "discourse/lib/preload-store";

export default {
  name: "discourse-custom-homepage",
  initialize() {
    withPluginApi("0.11.4", (api) => {
      // const router = container.lookup("router:main");
      const user = api.getCurrentUser();
      const { setDefaultHomepage } = require("discourse/lib/utilities");

      if (settings.custom_default_homepage) {
        const url = settings.custom_default_homepage.replace(/^\/+/g, '');
        setDefaultHomepage(url);
        PreloadStore.remove("topic_list");
      }

      if (!user && settings.anon_page) {
        const url = settings.anon_page.replace(/^\/+/g, '');

This file has been truncated. show original

Right. I’m using settings. How do I convince eslint that they are defined? I’ve looked at a bunch of other exemplars (like discourse-brand-header/javascripts/discourse/initializers/initialize-mobile-decorator.js at main · discourse/discourse-brand-header · GitHub) and tney don’t seem to be defining settings.

david
(David Taylor)

December 14, 2023, 4:07pm

3

In theory this should be handled by the eslint config you’re importing from our shared lint-configs

github.com

discourse/lint-configs/blob/main/lint-configs/eslint-theme.cjs#L7-L10


      
          globals: {
            settings: "readonly",
            themePrefix: "readonly",
          },

But it seems like that’s not working for some reason…

2 Likes

merefield
(Robert)

December 14, 2023, 4:08pm

4

Yeah, make sure you read this @pfaffman if you’ve not done so already

github.com

discourse/lint-configs/blob/main/lint-configs/README.md

# @discourse/lint-configs

Shareable lint configs for Discourse core, plugins, and themes

## Usage

Add `@discourse/lint-configs` to package.json, and create these three files:

### .eslintrc.cjs

```js
module.exports = require("@discourse/lint-configs/eslint");
```

or in themes/theme components:

```js
module.exports = require("@discourse/lint-configs/eslint-theme");
```

This file has been truncated. show original

CvX
(Jarek Radosz)

December 14, 2023, 4:11pm

5

Hm, maybe there’s an incompatibility between the newest eslint config and es6 files. Could you see if the errors persist after dropping the .es6 suffixes?

3 Likes

Source link